Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zeta Ssp Bid Adapter: support for eids #6819

Merged
merged 10 commits into from
May 28, 2021
Merged

Zeta Ssp Bid Adapter: support for eids #6819

merged 10 commits into from
May 28, 2021

Conversation

asurovenko-zeta
Copy link
Contributor

@asurovenko-zeta asurovenko-zeta commented May 24, 2021 •
edited
Loading

Type of change

  • Feature

Description of change

Implementation of SharedId system.

In prebid.setConfig we will add the follow lines to configure SharedId:

  userSync: {
    userIds: [
      {
        name: "sharedId",
        params: {
          syncTime: 60
        },
        storage: {
          type: "cookie",
          name: "sharedid",
          expires: 28
        }
      }
    ]
  }

Can you check please, that Prebid configuration and implementation are correct?
Thanks!

@asurovenko-zeta asurovenko-zeta changed the title Shared id implementation Zeta Ssp Bid Adapter: Shared id implementation May 24, 2021
@ChrisHuie
Copy link
Collaborator

@asurovenko-zeta can you please add test coverage for this pr 🙏

@asurovenko-zeta
Copy link
Contributor Author

@ChrisHuie done, test are added

FilipStamenkovic
FilipStamenkovic suggested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good.
Just a little note, with your code you didn't just add 'sharedId' to your request, you added all configured userIds. You can run your bidder on userId_example.html example page and you will see 8 different userIds passed in the request.
Is this what you want? Or you just want sharedId?

Also, please open docs PR.

@asurovenko-zeta
Copy link
Contributor Author

Yes, we want all userIds.
I'll create docs PR.
Thanks!

smenzer
smenzer requested changes May 25, 2021
View reviewed changes
modules/zetaSspBidAdapter.js Outdated Show resolved Hide resolved
smenzer
smenzer approved these changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FilipStamenkovic
FilipStamenkovic approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Before merging it, can you provide url to the docs PR?

@patmmccann patmmccann changed the title Zeta Ssp Bid Adapter: Shared id implementation Zeta Ssp Bid Adapter: support for eids May 25, 2021
@asurovenko-zeta
Copy link
Contributor Author

@FilipStamenkovic
Docs PR url:
prebid/prebid.github.io#2989

@FilipStamenkovic
Copy link
Contributor

@asurovenko-zeta Take a look at my comment on the docs PR: prebid/prebid.github.io#2989 (comment)

@asurovenko-zeta
Copy link
Contributor Author

@FilipStamenkovic I pushed the commit by your comment

@patmmccann
Copy link
Collaborator

Hi @asurovenko-zeta

Please resolve conflict and state which ids you support, it appears you read many ids beyond sharedid, do you ignore the others?

@asurovenko-zeta
Copy link
Contributor Author

@patmmccann I accept all ids, I changed docs PR with it information. Thanks

@patmmccann patmmccann merged commit 6f81c16 into prebid:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipStamenkovic FilipStamenkovic FilipStamenkovic approved these changes

@smenzer smenzer smenzer approved these changes

Assignees

@FilipStamenkovic FilipStamenkovic

@SKOCHERI SKOCHERI

Labels
maintenance minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@asurovenko-zeta @ChrisHuie @FilipStamenkovic @patmmccann @smenzer @SKOCHERI @surovenko